fix: More issues from feedback #172
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
lukashaertel
commented
Sep 13, 2024
lukashaertel
commented
- Dealer and event fave button style adjusted, wasn't clear.
- Header hit slop fixed.
- Global search type detection moved to actual type tagging (dealer had no registration number).
- Map styling adjusted to allow for minimum pad, percent styles did not work properly.
- Search selector for global adjusted to create the tagged objects.
- Version of map view updated
lukashaertel
force-pushed
the
fix/second-feedback-round
branch
from
50b0358
to
edddbea
Compare
* Dealer and event fave button style adjusted, wasn't clear. * Header hit slop fixed. * Global search type detection moved to actual type tagging (dealer had no registration number). * Map styling adjusted to allow for minimum pad, percent styles did not work properly. * Search selector for global adjusted to create the tagged objects. * Version of map view updated
lukashaertel
force-pushed
the
fix/second-feedback-round
branch
from
edddbea
to
f8583ca
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.